Move o.e.m2e.maven.runtime to m2e's git-repo root #1492
Conversation
HannesWell
force-pushed
the
topLevelMavenRuntime
branch
3 times, most recently
from
16071f1
to
8a2abfa
Compare
|
Somehow the feature's build-qualifier does not take the version and qualifier change of o.e.m2e.maven.runtime into account: And consequently the feature is replaced with the baseline from the snapshot. |
If you think it helps managing m2e build why not :-) |
HannesWell
force-pushed
the
topLevelMavenRuntime
branch
from
8a2abfa
to
711a7d1
Compare
You need to bump the version manually, the qualifier update will likely miss non Tycho projects. |
Was this always required? IIRC in the past, this was not necessary. But this was likely in the time, when the m2e.maven.runtime participated as regular Eclipse Plugin in the build. Do you think it would be feasible to also consider non Eclipse Plugin Projects when computing the qualifier? |
|
The qualifier computation is quite fragile already and requires a special naming of artifacts/bundles so I'm not sure it is worth to invest more time as necessary but if you like you can debug the case and check why it is not considered. |
Since o.e.m2e.maven.runtime is the only remaining module in m2e-maven-runtime there is no need anymore to keep the general build configuration separated.
and delete the now empty m2e-maven-runtime project. Since o.e.m2e.maven.runtime is the only remaining module in m2e-maven-runtime there is no need anymore to keep m2e-maven-runtime as its parent project.
HannesWell
force-pushed
the
topLevelMavenRuntime
branch
from
711a7d1
to
728d019
Compare
Understand. Then lets keep this as task for the future. Since we will encounter this problem on every maven update, I think the chances are not too low, that one is annoyed enough bis this in the future.^^ |
Since
o.e.m2e.maven.runtimeis the only remaining module in m2e-maven-runtime there is no need anymore to keepm2e-maven-runtimeas its parent project and the general build configuration separated.@laeubi any objection?